Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Better scroll #38199

Merged
merged 1 commit into from
Mar 10, 2023
Merged

Docs: Better scroll #38199

merged 1 commit into from
Mar 10, 2023

Conversation

louismaximepiton
Copy link
Member

Description

Removing :focus.
Removing * and replacing it by more specific selector.
Adding a scroll-margin-bottom.

Motivation & Context

Didn't work on FF.
Performance issue using the universal selector.
Avoid sticking to the very bottom of the page.

Type of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would change existing functionality)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • (NA) My change introduces changes to the documentation
  • (NA) I have updated the documentation accordingly
  • (NA) I have added tests to cover my changes
  • All new and existing tests passed

Live previews

Related issues

NA

@mdo mdo merged commit 1f7e7eb into main Mar 10, 2023
@mdo mdo deleted the main-lmp-better-docs-focus branch March 10, 2023 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants